Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7950][VL] Keep Core module's build flag consistent with Velox #8027

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

surnaik
Copy link
Contributor

@surnaik surnaik commented Nov 23, 2024

  1. Keep build flags consistent with Velox Module in cpp/velox/CMakeList.txt
  2. Keep velox build flag to default to increase coverage of targeted CPU Platforms

How was this patch tested?

Local Build and tested on multiple GCE VMs - N1, N2, C2, N2D, C2D etc

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@surnaik
Copy link
Contributor Author

surnaik commented Nov 23, 2024

@PHILO-HE / @FelixYBW please review. Thanks!

@PHILO-HE
Copy link
Contributor

@surnaik, thanks so much for your pr and test feedback! We already have a draft pr to fix this issue: #7916.
And I think we should set flags in root CMakeLists.txt to make them applied consistently across all submodules.
cc @zhouyuan

@surnaik
Copy link
Contributor Author

surnaik commented Nov 23, 2024

@surnaik, thanks so much for your pr and test feedback! We already have a draft pr to fix this issue: #7916. And I think we should set flags in root CMakeLists.txt to make them applied consistently across all submodules. cc @zhouyuan

Thanks @PHILO-HE , You may please close this PR if Yuan is already fixing it, didn't notice it.

@zhouyuan zhouyuan changed the title [VL] Keep Core module's build flag consistent with Velox [GLUTEN-7950][VL] Keep Core module's build flag consistent with Velox Nov 25, 2024
Copy link

#7950

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
thanks for the fix, looks good to me. We are discussing if we could make another profile so some AVX512 instructions can be used inside Gluten. I will try to improve more on this part

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this pr firstly. @surnaik, thanks so much for your work!

@PHILO-HE PHILO-HE merged commit 35de38f into apache:main Nov 25, 2024
47 checks passed
@surnaik
Copy link
Contributor Author

surnaik commented Nov 25, 2024

Thanks @PHILO-HE , as you suggested, let me actually clean it up and add it to the top level CMakeList.txt

@zhouyuan
Copy link
Contributor

#8041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants