-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7950][VL] Keep Core module's build flag consistent with Velox #8027
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Thanks @PHILO-HE , You may please close this PR if Yuan is already fixing it, didn't notice it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
thanks for the fix, looks good to me. We are discussing if we could make another profile so some AVX512 instructions can be used inside Gluten. I will try to improve more on this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land this pr firstly. @surnaik, thanks so much for your work!
Thanks @PHILO-HE , as you suggested, let me actually clean it up and add it to the top level CMakeList.txt |
How was this patch tested?
Local Build and tested on multiple GCE VMs - N1, N2, C2, N2D, C2D etc