-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL][GLUTEN-8020] Remove the libhdfs3 installation script required for static linking #8013
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@JkSelf, can we also remove |
@JkSelf could you please help to link with the right Issue? |
Seems we still need it for deciding whether to register hdfs filesystem. |
Yes. We also need to pass the enable_hdfs to velox compile scripts. |
@JkSelf is document updated? |
The changes is helpful for #7977 , libhdfs3 compile issue found during the test. I will bypass the libhdfs3. |
What changes were proposed in this pull request?
We will only retain the dynamic libraries libhdfs.so or libhdfs3.so at runtime based on this benchmark here. So there is no need to keep the libhdfs3 installation script required for static linking.
How was this patch tested?
Existing compile scripts.