Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7126][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix #7994

Merged
merged 8 commits into from
Nov 23, 2024

Conversation

weiting-chen
Copy link
Contributor

What changes were proposed in this pull request?

Port #6698 #7525 #7560 to fix Uniffle related bug fix in branch-1.2

How was this patch tested?

local

@weiting-chen weiting-chen changed the title [VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix [DNM][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix Nov 19, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor

Seem CI failure is related. @SteNicholas, @wForget

 /root/.m2/repository/org/apache/uniffle/rss-client-spark3-shaded/0.8.0/rss-client-spark3-shaded-0.8.0.jar(org/apache/spark/shuffle/RssShuffleManager.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found
Error:  /__w/incubator-gluten/incubator-gluten/gluten-uniffle/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java:[199,16] error: cannot find symbol
Error:    symbol:   class RssException
Error:    location: class VeloxUniffleColumnarShuffleWriter<K,V>

@PHILO-HE
Copy link
Contributor

@weiting-chen, the uniffle test fails which should be related.

@zhouyuan zhouyuan changed the title [DNM][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix [GLUTEN-7126][DNM][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix Nov 21, 2024
Copy link

#7126

@summaryzb
Copy link
Contributor

@weiting-chen the changes of gluten-uniffle/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java is made in #6579 should not be include in this pr.
cc @PHILO-HE @jackylee-ch

@weiting-chen weiting-chen changed the title [GLUTEN-7126][DNM][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix [GLUTEN-7126][VL][1.2] Port #6698 #7525 #7560 for Uniffle bug fix Nov 23, 2024
@weiting-chen
Copy link
Contributor Author

@PHILO-HE Please help to review it, thanks.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit abf0e1d into apache:branch-1.2 Nov 23, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants