[GLUTEN-7900][VL] Enable prefix sort in spill #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhztheplayer
changed the title
|
Would you like to refer the related Velox PRs for this feature in PR description? Which will help users to track. Thanks. I'm also thinking about setting up a more comprehensive integration benchmark for spill performance. The following is by the existing GHA oom tests: Before:
After:
|
|
We have a spill performance in internal Jenkins, I have trigger it. It will run after machine is ready since serves down today. |
|
Let's put the jenkins performance here. |
jinchengchenghh
force-pushed
the
spill
branch
from
250f5f3
to
5426fb8
Compare
jinchengchenghh
force-pushed
the
spill
branch
from
3edb3eb
to
3d2fc1d
Compare
This reverts commit 3d2fc1d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix sort can reduce the spill sort time by 3x with the sampled Meta production query but timsort increase the sort time by 20%. So timsort performance seems depends on the actual data pattern.
After pick this PR facebookincubator/velox#11527, a query in jenkins spill with string is 41s prefixsort vs 37s timsort vs 63s stdsort.
Relevant Velox PR: facebookincubator/velox#11384
Resolves #7900