-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Add write IO metrics for WriteFiles #7011
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
depends on #7002 |
@@ -182,6 +183,7 @@ object MetricsUtil extends Logging { | |||
ioWaitTime, | |||
preloadSplits, | |||
physicalWrittenBytes, | |||
writeIOTime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you missed the merge code?
59a6aa6
to
f581634
Compare
cc @PHILO-HE @liujiayi771 thank you! |
@Yohahaha Can you confirm, there is a list for merging metric values https://github.com/Yohahaha/gluten/blob/f58163433b83453b772d76a158503bb1a77e28ad/gluten-data/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala#L129-L153 and whether we should append some code into that list. |
I see, TableWriter count why we need merge those metrics? |
Sorry, I am not aside a dev PC now, so I can't actually reason about the code, which looks too magical to me by the way. But what's clear is only input and output metrics were being handled separately when the code was firstly written .
After all, I think we should make these 4 metrics consistent. Either merge them all, or none of them. And seems to be safe to merge them all by taking the first look. cc @JkSelf |
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|
No description provided.