Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7008][VL] Report spill metrics from Velox operators to Spark task #7009

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Aug 26, 2024

#7008

Example:
image

@github-actions github-actions bot added the VELOX label Aug 26, 2024
Copy link

#7008

@zhztheplayer
Copy link
Member Author

cc @marin-ma

Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zhztheplayer zhztheplayer merged commit e399dc3 into apache:main Aug 26, 2024
44 checks passed
@FelixYBW
Copy link
Contributor

FelixYBW commented Aug 27, 2024

To record, the disk spill size is compariable, memory is not.
Gluten:
image

Vanilla:
image

sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants