-
Notifications
You must be signed in to change notification settings - Fork 439
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
window group limit has bad performance
- Loading branch information
Showing
8 changed files
with
217 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #include "SortUtils.h" | ||
| #include <IO/Operators.h> | ||
| #include <IO/WriteBufferFromString.h> | ||
| #include <Poco/Logger.h> | ||
| #include <Common/Exception.h> | ||
| #include <Common/logger_useful.h> | ||
|
|
||
| namespace DB::ErrorCodes | ||
| { | ||
| extern const int BAD_ARGUMENTS; | ||
| extern const int LOGICAL_ERROR; | ||
| } | ||
|
|
||
| namespace local_engine | ||
| { | ||
| DB::SortDescription parseSortFields(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::Expression> & expressions) | ||
| { | ||
| DB::SortDescription description; | ||
| for (const auto & expr : expressions) | ||
| if (expr.has_selection()) | ||
| { | ||
| auto pos = expr.selection().direct_reference().struct_field().field(); | ||
| const auto & col_name = header.getByPosition(pos).name; | ||
| description.push_back(DB::SortColumnDescription(col_name, 1, 1)); | ||
| } | ||
| else if (expr.has_literal()) | ||
| continue; | ||
| else | ||
| throw DB::Exception(DB::ErrorCodes::BAD_ARGUMENTS, "Unknow expression as sort field: {}", expr.DebugString()); | ||
| return description; | ||
| } | ||
|
|
||
| DB::SortDescription parseSortFields(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::SortField> & sort_fields) | ||
| { | ||
| static std::map<int, std::pair<int, int>> direction_map = {{1, {1, -1}}, {2, {1, 1}}, {3, {-1, 1}}, {4, {-1, -1}}}; | ||
|
|
||
| DB::SortDescription sort_descr; | ||
| for (int i = 0, sz = sort_fields.size(); i < sz; ++i) | ||
| { | ||
| const auto & sort_field = sort_fields[i]; | ||
| /// There is no meaning to sort a const column. | ||
| if (sort_field.expr().has_literal()) | ||
| continue; | ||
|
|
||
| if (!sort_field.expr().has_selection() || !sort_field.expr().selection().has_direct_reference() | ||
| || !sort_field.expr().selection().direct_reference().has_struct_field()) | ||
| { | ||
| throw DB::Exception(DB::ErrorCodes::LOGICAL_ERROR, "Unsupport sort field"); | ||
| } | ||
| auto field_pos = sort_field.expr().selection().direct_reference().struct_field().field(); | ||
|
|
||
| auto direction_iter = direction_map.find(sort_field.direction()); | ||
| if (direction_iter == direction_map.end()) | ||
| throw DB::Exception(DB::ErrorCodes::LOGICAL_ERROR, "Unsuppor sort direction: {}", sort_field.direction()); | ||
| const auto & col_name = header.getByPosition(field_pos).name; | ||
| sort_descr.emplace_back(col_name, direction_iter->second.first, direction_iter->second.second); | ||
| } | ||
| return sort_descr; | ||
| } | ||
|
|
||
| std::string | ||
| buildSQLLikeSortDescription(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::SortField> & sort_fields) | ||
| { | ||
| static const std::unordered_map<int, std::string> order_directions | ||
| = {{1, " asc nulls first"}, {2, " asc nulls last"}, {3, " desc nulls first"}, {4, " desc nulls last"}}; | ||
| size_t n = 0; | ||
| DB::WriteBufferFromOwnString ostr; | ||
| for (const auto & sort_field : sort_fields) | ||
| { | ||
| auto it = order_directions.find(sort_field.direction()); | ||
| if (it == order_directions.end()) | ||
| throw DB::Exception(DB::ErrorCodes::BAD_ARGUMENTS, "Unknow sort direction: {}", sort_field.direction()); | ||
| if (!sort_field.expr().has_selection()) | ||
| { | ||
| throw DB::Exception( | ||
| DB::ErrorCodes::BAD_ARGUMENTS, "Sort field must be a column reference. but got {}", sort_field.DebugString()); | ||
| } | ||
| auto ref = sort_field.expr().selection().direct_reference().struct_field().field(); | ||
| const auto & col_name = header.getByPosition(ref).name; | ||
| if (n) | ||
| ostr << String(","); | ||
| // the col_name may contain '#' which can may ch fail to parse. | ||
| ostr << "`" << col_name << "`" << it->second; | ||
| n += 1; | ||
| } | ||
| LOG_DEBUG(getLogger("AggregateGroupLimitRelParser"), "Order by clasue: {}", ostr.str()); | ||
| return ostr.str(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
| #include <Core/Block.h> | ||
| #include <Core/SortDescription.h> | ||
| #include <google/protobuf/repeated_field.h> | ||
| #include <substrait/plan.pb.h> | ||
|
|
||
| namespace local_engine | ||
| { | ||
| // convert expressions into sort description | ||
| DB::SortDescription | ||
| parseSortFields(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::Expression> & expressions); | ||
| DB::SortDescription parseSortFields(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::SortField> & sort_fields); | ||
|
|
||
| std::string | ||
| buildSQLLikeSortDescription(const DB::Block & header, const google::protobuf::RepeatedPtrField<substrait::SortField> & sort_fields); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.