Arrow, AWS, Core: Remove deprecated code for 1.5.0 release #9505
Conversation
|
Can we combine this PR with other deprecations that should be removed before releasing 1.5.0? I think there aren't too many |
I don't want to combine #9298 with this change as it will be hard to review when we mix things. If there are direct removals, we can combine with this PR. I did a look up the remaining and only thing that is pending after this is deprecation from |
|
I didn't mean to combine it with #9298, but rather with any other deprecations that haven't been done yet. Searching through the codebase using |
|
Sure. |
ajantha-bhat
changed the title
|
Only thing left is deprecated code in |
ajantha-bhat
changed the title
|
I pushed the changed from AWS module as a separate commit in the same PR. |
| import org.assertj.core.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class TestAwsProperties { |
There was a problem hiding this comment.
It was testing only deprecated awsProperties.httpClientProperties(). Since it is removed, There is no need of the test class.
Now we use HttpClientProperties instead which is already covered by HttpClientPropertiesTest
There was a problem hiding this comment.
it seems the purpose of this test was to check that Kryo ser/de works. Therefore we should keep this test (although using non-deprecated properties)
There was a problem hiding this comment.
ok. Added a test to verify some basic properties.
No description provided.