Check stale issues in ascending order #9489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have so many issues that only latest ones are checked for staleness due to rate limit
| @@ -47,3 +47,4 @@ jobs: | |||
| close-issue-message: > | |||
| This issue has been closed because it has not received any activity in the last 14 days | |||
| since being marked as 'stale' | |||
| ascending: true | |||
There was a problem hiding this comment.
It does make sense to close the older stale issues first. But I was wondering was there any default limit to number of issues to be processed? Why it is not closing all the issues that are older than 180 days and stale for 14 days.
There was a problem hiding this comment.
The default value is 30 as per https://github.com/actions/stale#operations-per-run
There was a problem hiding this comment.
the workflow triggers daily at midnight, considering 30 issues a day. It should have closed by now?
There was a problem hiding this comment.
With the default descending order, it always checks the latest issues and only a small amount can be closed. Older issues are never checked.
nastra
approved these changes
Jan 17, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
We have so many issues that only latest ones are checked for staleness due to rate limit
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
We have so many issues that only latest ones are checked for staleness due to rate limit
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
We have so many issues that only latest ones are checked for staleness due to rate limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have so many issues that only latest ones are checked for staleness due to rate limit.