Spark: propagate snapshot properties for RewriteDataFiles and RewritePositionDeleteFiles #9449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PositionDeleteFiles
|
cc @RussellSpitzer @szehon-ho or @aokolnychyi, would you mind to take a look at this since you guys touched most parts of the rewrite data files actions. |
|
@advancedxy: GH actions are down. Hence PR builders are failing. We need to wait till the status is green in https://www.githubstatus.com/ |
Thanks for the heads up. I was wondering it’s an occasional incident and tried rerunning the CI. Let’s wait GH actions back to normal. |
manuzhang
reviewed
Jan 10, 2024
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
Outdated
Show resolved
Hide resolved
manuzhang
reviewed
Jan 10, 2024
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Show resolved
Hide resolved
|
Gently ping @ajantha-bhat @ajantha-bhat @szehon-ho @aokolnychyi |
ajantha-bhat
approved these changes
Jan 16, 2024
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
Outdated
Show resolved
Hide resolved
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Outdated
Show resolved
Hide resolved
|
I will take a look this week. |
aokolnychyi
approved these changes
Jan 18, 2024
|
Thanks, @advancedxy! Thanks for reviewing, @manuzhang @ajantha-bhat! |
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
RewriteDataFiles, I noticed that the snapshot properties cannot be set viasnapshotProperty(String, String). This PR will fix that issue by propagating snapshot properties intoRewriteDataFilesCommitManagerorRewritePositionDeletesCommitManagerand all the way down toRewriteFiles.