Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Extract Gradle version from gradle-wrapper.properties #9448

Closed
wants to merge 1 commit into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 9, 2024

The Iceberg customized gradlew to avoid tracking gradle-wrapper.jar in Git. But changing the download link each time seems too fragile, this PR aims to extract the Gradle version from gradle-wrapper.properties and dynamically generate the download link

@github-actions github-actions bot added the build label Jan 9, 2024
@pan3793
Copy link
Member Author

pan3793 commented Jan 9, 2024

We can not use bash extensions like [[ string =~ regex ]] because of

#   (2) This script targets any POSIX shell, so it avoids extensions provided
#       by Bash, Ksh, etc; in particular arrays are avoided.

The code may be ugly, any suggestion is welcome.

@pan3793
Copy link
Member Author

pan3793 commented Jan 10, 2024

cc @nastra

Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 13, 2024
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant