Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove unused sourceTransform parameter in helper method #9379

Merged
merged 1 commit into from
Dec 25, 2023
+2 −3
Merged

Core: Remove unused sourceTransform parameter in helper method #9379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,7 @@ public BaseUpdatePartitionSpec addField(Term term) {
return addField(null, term);
}

private BaseUpdatePartitionSpec rewriteDeleteAndAddField(
PartitionField existing, String name, Pair<Integer, Transform<?, ?>> sourceTransform) {
private BaseUpdatePartitionSpec rewriteDeleteAndAddField(PartitionField existing, String name) {
deletes.remove(existing.fieldId());
if (name == null || existing.name().equals(name)) {
return this;
Expand All @@ -180,7 +179,7 @@ public BaseUpdatePartitionSpec addField(String name, Term term) {
if (existing != null
&& deletes.contains(existing.fieldId())
&& existing.transform().equals(sourceTransform.second())) {
return rewriteDeleteAndAddField(existing, name, sourceTransform);
return rewriteDeleteAndAddField(existing, name);
}

Preconditions.checkArgument(
Expand Down