Core, Spark: Avoid manifest copies when importing data to V2 tables #8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
force-pushed
the
avoid-manifest-copies-append
branch
from
a9ca63f to
5780b82
Compare
aokolnychyi
commented
Nov 1, 2023
| * <p>By default, the manifest will be rewritten to assign all entries this update's snapshot ID. | ||
| * In that case, it is always the responsibility of the caller to manage the lifecycle of the | ||
| * original manifest. | ||
| * <p>The manifest will be used directly if snapshot ID inheritance is enabled (all tables with |
There was a problem hiding this comment.
Simply clarifies the notion of snapshot ID inheritance and that it is always on in V2 tables.
aokolnychyi
force-pushed
the
avoid-manifest-copies-append
branch
from
5780b82 to
6d9d78b
Compare
aokolnychyi
force-pushed
the
avoid-manifest-copies-append
branch
2 times, most recently
from
fea275d to
9b2b93a
Compare
szehon-ho
approved these changes
Dec 12, 2023
| * the commit fails, the manifest will never be deleted and it is up to the caller whether to | ||
| * delete or reuse it. | ||
| * <p>If the manifest is rewritten, it is always the responsibility of the caller to manage the | ||
| * lifecycle of the original manifest. If manifest entries are allowed to inherit the snapshot ID |
There was a problem hiding this comment.
What do you think to simplify 'if manifest entries are allowed to inherit the snapshot ID...' to 'if the manifest is used directly'..?
There was a problem hiding this comment.
Yep, I liked it. Fixed.
aokolnychyi
force-pushed
the
avoid-manifest-copies-append
branch
from
2b5eed9 to
7f6a798
Compare
|
Thanks, @szehon-ho! |
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the idea from #8928 to
FastAppendandMergeAppend, which are used in data imports and migration.