Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.x] Core: Do not use a lazy split offset list in manifests (#8834) #8845

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Oct 16, 2023

This backports #8834 to 1.4.1

The list was not correctly invalidated when reusing the file.
@nastra nastra added this to the Iceberg 1.4.1 milestone Oct 16, 2023
@github-actions github-actions bot added the core label Oct 16, 2023
@nastra nastra changed the title Core: Do not use a lazy split offset list in manifests (#8834) [1.4.x] Core: Do not use a lazy split offset list in manifests (#8834) Oct 16, 2023
Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @nastra !

@rdblue rdblue merged commit 8aa948f into apache:1.4.x Oct 17, 2023
45 checks passed
@nastra nastra deleted the offset-read-fix-1.4.1 branch October 17, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants