Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet: parquet/*: replaced .size() > 0 with isEmpty() #8816

Closed
wants to merge 1 commit into from
Closed

Parquet: parquet/*: replaced .size() > 0 with isEmpty() #8816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ private boolean eval(
Binder.boundReferences(schema.asStruct(), ImmutableList.of(expr), caseSensitive);
// If the filter's column set doesn't overlap with any bloom filter columns, exit early with
// ROWS_MIGHT_MATCH
if (filterRefs.size() > 0 && Sets.intersection(fieldsWithBloomFilter, filterRefs).isEmpty()) {
if (!filterRefs.isEmpty() && Sets.intersection(fieldsWithBloomFilter, filterRefs).isEmpty()) {
return ROWS_MIGHT_MATCH;
}

Expand Down