OpenAPI: Add description for AssignUUID #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
referenced
this pull request
Oct 9, 2023
amogh-jahagirdar
approved these changes
Oct 9, 2023
singhpk234
reviewed
Oct 9, 2023
| @@ -230,6 +230,10 @@ class BaseUpdate(BaseModel): | |||
|
|
|||
|
|
|||
| class AssignUUIDUpdate(BaseUpdate): | |||
| """ | |||
| Assigning a UUID to a table/view should only be done when creating the table/view. It is not safe to re-assign the UUID if a table/view already has a UUID assigned | |||
There was a problem hiding this comment.
wondering if we expect the services to throw some validation exp or BadRequest in case there already exists a table and if yes should we document this here ?
There was a problem hiding this comment.
@singhpk234 this is being handled by the TableRequirement section, more specifically, there is assert-create:
iceberg/open-api/rest-catalog-open-api.yaml
Line 1831 in 621d301
|
thanks everyone for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a description based on feedback from dd26f36#r129277242