-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master branch to main #8722
Conversation
.github/workflows/spark-ci.yml
Outdated
**/build/testlogs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unrelated modification?
docs/metrics-reporting.md
Outdated
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
@jbonofre, how will this affect existing PRs? Do all of them need to be reopened against main instead of master? |
@rdblue no impact on the existing PRs: they will be "attached" to main instead of master. The only impact is for the remotes for our users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is good to go when the rename has happened.
Thanks, I do a cleanup on this PR and I create a INFRA ticket to actually rename. |
@ajantha-bhat I did a rebase to remove the python related resources, and the "formatting" should be OK now. |
As soon as @ajantha-bhat vote +1 on this PR, I will create the ticket at Apache INFRA to trigger the rename. |
@jbonofre: LGTM. Thanks for fixing the formatting too. |
Thanks @jbonofre for taking the lead on this! |
This PR rename resources using
master
tomain
. This PR should be merged only when the renaming has been done by Apache INRA.