Flink: port table refresh (#8555) to v1.15 and v1.16 #8616
Conversation
| @@ -379,7 +379,7 @@ public void testWriteRowWithTableRefreshInterval() throws Exception { | |||
| .map(CONVERTER::toInternal, FlinkCompatibilityUtil.toTypeInfo(SimpleDataUtil.ROW_TYPE)); | |||
|
|
|||
| Configuration flinkConf = new Configuration(); | |||
| flinkConf.setString(FlinkWriteOptions.TABLE_REFRSH_INTERVAL.key(), "100ms"); | |||
| flinkConf.setString(FlinkWriteOptions.TABLE_REFRESH_INTERVAL.key(), "100ms"); | |||
There was a problem hiding this comment.
Thanks for fixing this!
| @@ -18,6 +18,8 @@ | |||
| */ | |||
| package org.apache.iceberg.flink; | |||
|
|
|||
| import java.time.Duration; | |||
| import org.apache.calcite.linq4j.function.Experimental; | |||
There was a problem hiding this comment.
looks like the wrong import is being used here
| import java.util.Map; | ||
| import org.apache.calcite.linq4j.function.Experimental; |
There was a problem hiding this comment.
if we fix this one we should also fix it for flink 1.17
There was a problem hiding this comment.
Hm, apologies, I fixed these.
|
@bryanck: is this a clean backport? We tend to fix, change everything in 1.17 code , and then do a clean backport to 1.16, 1.15 whenever possible. If there is some change, we highlight it in comments on github. |
|
@pvary This is a clean backport. Two minor items were discovered on this review which were applied to all versions, I added those to the description. |
There was a problem hiding this comment.
LGTM, thanks @bryanck. Also thanks to @Fokko / @amogh-jahagirdar / @pvary for reviewing
Thanks! |
This PR ports the changes from #8555 (optional table refresh) to Flink version 1.15 and 1.16.
This includes two minor updates for all versions, that were missed in the original PR:
TABLE_REFRSH_INTERVAL->TABLE_REFRESH_INTERVALorg.apache.calcite.linq4j.function.Experimental->org.apache.flink.annotation.Experimental