Spark 3.5: Fix metrics reporting in distributed planning #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Sep 21, 2023
| @@ -53,6 +53,10 @@ public BaseTable(TableOperations ops, String name, MetricsReporter reporter) { | |||
| this.reporter = reporter; | |||
| } | |||
|
|
|||
| MetricsReporter reporter() { | |||
There was a problem hiding this comment.
The simplest approach is to just expose the reporter with package-private access.
We could have an interface called HasMetricsReporter, similar to HasTableOperations. It will be a bit more generic but it is not required for this PR. Let me know.
There was a problem hiding this comment.
this should be fine. In fact, I'm making it public in https://github.com/apache/iceberg/pull/8032/files#diff-725c9531623b4e47248f10a8caac9b18ead6906101efdf7e8c14c6363b3b6d59R267
There was a problem hiding this comment.
Oh, good to know!
nastra
approved these changes
Sep 21, 2023
|
Thanks, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes metrics reporting in distributed planning:
SparkDistributedDataScanpicks up the base reporter configured for the table.SparkDistributedDataScancorrectly computes the number of skipped data and delete files.