Remove number from assert description #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
reviewed
Dec 19, 2024
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
szehon-ho
reviewed
Dec 19, 2024
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
Update description remove should have
TQJADE
force-pushed
the
qi-main
branch
2 times, most recently
from
5ae58d6 to
d859031
Compare
szehon-ho
reviewed
Dec 19, 2024
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
...ark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
Outdated
Show resolved
Hide resolved
szehon-ho
approved these changes
Dec 20, 2024
|
You can check the failure, can you run |
|
@TQJADE Please run |
|
Thanks @TQJADE for your first Iceberg contribution 🎉 , and thanks @huaxingao for the guidance and review ! @TQJADE Feel free to do the same for other test as well if applicable. |
|
Thanks a lot for your reviewing @szehon-ho @huaxingao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the suggestions in: https://github.com/apache/iceberg/pull/11748/files/36d953f359e58d4f01f45a7783cf3ae01d52c59b#r1880821876