Spark 3.5: Support default values in Parquet reader #11803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
approved these changes
Dec 18, 2024
|
For the context, is this PR (and previous PRs) resolving #10761? |
Fokko
approved these changes
Dec 18, 2024
| * @param value a value that is an instance of {@link Type.TypeID#javaClass()} | ||
| * @return the value converted for Spark | ||
| */ | ||
| public static Object convertConstant(Type type, Object value) { |
There was a problem hiding this comment.
I know that this is a copy of the other one, but I would also expect UUID to be here.
There was a problem hiding this comment.
Good point, I'll update it in my follow up that is fixing a few types and adding a test for each primitive. I need to make some changes on top of this one, so it makes sense to do all of the primitive type fixes at the same time.
There was a problem hiding this comment.
The follow up will be here: #11811
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #11785 but updates the Spark readers.