Core: Fix loading a table in CachingCatalog with metadata table name #11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative solution to #11123 |
gaborkaszab
force-pushed
the
main_caching_catalog_fix
branch
from
efe4626 to
34d69e6
Compare
manuzhang
reviewed
Dec 10, 2024
| // share TableOperations instance of origin table for all metadata tables, so that metadata | ||
| // table instances are | ||
| // also refreshed as well when origin table instance is refreshed. | ||
| // Share TableOperations instance of origin table for all metadata tables, so that metadata |
There was a problem hiding this comment.
Do we still need code below when we already cache the metadata table above?
There was a problem hiding this comment.
It's needed to share the underlying TableOperations between the originTable and the metadata table. We basically create another Table object for the table metadata with a different TableOperations and then update the cache with that object.
|
I see you have made changes previously in CachingCatalog, @rdblue @aokolnychyi @RussellSpitzer . Would you mind taking a look at this PR? |
manuzhang
approved these changes
Dec 18, 2024
If a regular table had a metadata table name then CachingCatalog throws a NoSuchTableException when loading that table. Co-authored-by: Manu Zhang <[email protected]>
gaborkaszab
force-pushed
the
main_caching_catalog_fix
branch
from
34d69e6 to
aedfa9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a regular table had a metadata table name then CachingCatalog throws a NoSuchTableException when loading that table.