Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Align CharSequenceSet impl with Data/DeleteFileSet #11322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Oct 15, 2024

No description provided.

@github-actions github-actions bot added the API label Oct 15, 2024
@nastra nastra force-pushed the charseq-set-improvements branch from dba7900 to 887f641 Compare October 15, 2024 11:33
@nastra nastra force-pushed the charseq-set-improvements branch from 887f641 to 2b4592c Compare October 15, 2024 12:47

public class CharSequenceSet implements Set<CharSequence>, Serializable {
public class CharSequenceSet extends WrapperSet<CharSequence> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be easier to just look at the resulting file instead of the diff

@nastra nastra requested a review from aokolnychyi October 15, 2024 14:40
@nastra nastra changed the title Core: Align CharSequenceSet impl with Data/DeleteFileSet API: Align CharSequenceSet impl with Data/DeleteFileSet Oct 16, 2024
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 16, 2024
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 24, 2024
@nastra nastra reopened this Nov 25, 2024
@github-actions github-actions bot removed the stale label Nov 26, 2024
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 27, 2024
Copy link

github-actions bot commented Jan 3, 2025

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jan 3, 2025
@nastra nastra reopened this Jan 7, 2025
@nastra nastra added not-stale and removed stale labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant