Spark 3.3, 3.4: Fix incorrect catalog loaded in TestCreateActions #11049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
force-pushed
the
test-create-actions-backport
branch
from
a06418e to
3cdde2b
Compare
manuzhang
force-pushed
the
test-create-actions-backport
branch
from
3cdde2b to
5298462
Compare
nastra
reviewed
Sep 9, 2024
| @@ -728,6 +733,8 @@ public void testStructOfThreeLevelLists() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testTwoLevelList() throws IOException { | |||
| Assume.assumeTrue("Cannot migrate to a hadoop based catalog", !type.equals("hadoop")); | |||
There was a problem hiding this comment.
why not use Assumptions from AssertJ?
There was a problem hiding this comment.
These two tests haven't been converted to AssertJ yet.
nastra
approved these changes
Sep 9, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of #10952
cc @nastra