Use copyOf instead

apache · Oct 6, 2023 · fd4de66 · fd4de66
1 parent 73947f2
commit fd4de66
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 8 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/BaseSnapshot.java b/core/src/main/java/org/apache/iceberg/BaseSnapshot.java
@@ -139,7 +139,10 @@ private void cacheManifests(FileIO fileIO) {
           Lists.transform(
               Arrays.asList(v1ManifestLocations),
               location ->
-                  GenericManifestFile.copyOf(new GenericManifestFile(fileIO.newInputFile(location), 0)).withSnapshotId(this.snapshotId).build());
+                  GenericManifestFile.copyOf(
+                          new GenericManifestFile(fileIO.newInputFile(location), 0))
+                      .withSnapshotId(this.snapshotId)
+                      .build());
     }
 
     if (allManifests == null) {

diff --git a/core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java b/core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java
@@ -1236,9 +1236,14 @@ private String createManifestListWithManifestFiles(long snapshotId, Long parentS
 
     List<ManifestFile> manifests =
         ImmutableList.of(
-                GenericManifestFile.copyOf(new GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0)).withSnapshotId(snapshotId).build(),
-                GenericManifestFile.copyOf(new GenericManifestFile(localInput("file:/tmp/manifest2.avro"), 0)).withSnapshotId(snapshotId).build()
-        );
+            GenericManifestFile.copyOf(
+                    new GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0))
+                .withSnapshotId(snapshotId)
+                .build(),
+            GenericManifestFile.copyOf(
+                    new GenericManifestFile(localInput("file:/tmp/manifest2.avro"), 0))
+                .withSnapshotId(snapshotId)
+                .build());
 
     try (ManifestListWriter writer =
         ManifestLists.write(1, Files.localOutput(manifestList), snapshotId, parentSnapshotId, 0)) {

diff --git a/core/src/test/java/org/apache/iceberg/TestSnapshotJson.java b/core/src/test/java/org/apache/iceberg/TestSnapshotJson.java
@@ -176,9 +176,14 @@ private String createManifestListWithManifestFiles(long snapshotId, Long parentS
 
     List<ManifestFile> manifests =
         ImmutableList.of(
-                GenericManifestFile.copyOf(new GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0)).withSnapshotId(snapshotId).build(),
-                GenericManifestFile.copyOf(new GenericManifestFile(localInput("file:/tmp/manifest2.avro"), 0)).withSnapshotId(snapshotId).build(),
-                );
+            GenericManifestFile.copyOf(
+                    new GenericManifestFile(localInput("file:/tmp/manifest1.avro"), 0))
+                .withSnapshotId(snapshotId)
+                .build(),
+            GenericManifestFile.copyOf(
+                    new GenericManifestFile(localInput("file:/tmp/manifest2.avro"), 0))
+                .withSnapshotId(snapshotId)
+                .build());
 
     try (ManifestListWriter writer =
         ManifestLists.write(1, Files.localOutput(manifestList), snapshotId, parentSnapshotId, 0)) {

diff --git a/core/src/test/java/org/apache/iceberg/TestTableMetadata.java b/core/src/test/java/org/apache/iceberg/TestTableMetadata.java
@@ -1585,7 +1585,10 @@ private String createManifestListWithManifestFile(
         ManifestLists.write(1, Files.localOutput(manifestList), snapshotId, parentSnapshotId, 0)) {
       writer.addAll(
           ImmutableList.of(
-              GenericManifestFile.copyOf(new GenericManifestFile(localInput(manifestFile), SPEC_5.specId())).withSnapshotId(snapshotId).build()));
+              GenericManifestFile.copyOf(
+                      new GenericManifestFile(localInput(manifestFile), SPEC_5.specId()))
+                  .withSnapshotId(snapshotId)
+                  .build()));
     }
 
     return localInput(manifestList).location();