REST server might override the configured view location

apache · Oct 18, 2023 · d4f510d · d4f510d
1 parent 380c465
commit d4f510d
Showing 1 changed file with 31 additions and 5 deletions.
diff --git a/core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java b/core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java
@@ -61,6 +61,10 @@ protected boolean requiresNamespaceCreate() {
     return false;
   }
 
+  protected boolean overridesRequestedLocation() {
+    return false;
+  }
+
   @Test
   public void basicCreateView() {
     TableIdentifier identifier = TableIdentifier.of("ns", "view");
@@ -141,9 +145,14 @@ public void completeCreateView() {
     assertThat(catalog().viewExists(identifier)).as("View should exist").isTrue();
     assertThat(((BaseView) view).operations().current().metadataFileLocation()).isNotNull();
 
+    if (!overridesRequestedLocation()) {
+      assertThat(view.location()).isEqualTo("file://tmp/ns/view");
+    } else {
+      assertThat(view.location()).isNotNull();
+    }
+
     // validate view settings
     assertThat(view.name()).isEqualTo(ViewUtil.fullViewName(catalog().name(), identifier));
-    assertThat(view.location()).isEqualTo("file://tmp/ns/view");
     assertThat(view.properties()).containsEntry("prop1", "val1").containsEntry("prop2", "val2");
     assertThat(view.history())
         .hasSize(1)
@@ -1413,7 +1422,12 @@ public void createAndReplaceViewWithLocation() {
             .create();
 
     assertThat(catalog().viewExists(identifier)).as("View should exist").isTrue();
-    assertThat(view.location()).isEqualTo("file://tmp/ns/view");
+
+    if (!overridesRequestedLocation()) {
+      assertThat(view.location()).isEqualTo("file://tmp/ns/view");
+    } else {
+      assertThat(view.location()).isNotNull();
+    }
 
     view =
         catalog()
@@ -1424,7 +1438,11 @@ public void createAndReplaceViewWithLocation() {
             .withLocation("file://updated_tmp/ns/view")
             .replace();
 
-    assertThat(view.location()).isEqualTo("file://updated_tmp/ns/view");
+    if (!overridesRequestedLocation()) {
+      assertThat(view.location()).isEqualTo("file://updated_tmp/ns/view");
+    } else {
+      assertThat(view.location()).isNotNull();
+    }
 
     assertThat(catalog().dropView(identifier)).isTrue();
     assertThat(catalog().viewExists(identifier)).as("View should not exist").isFalse();
@@ -1450,13 +1468,21 @@ public void updateViewLocation() {
             .create();
 
     assertThat(catalog().viewExists(identifier)).as("View should exist").isTrue();
-    assertThat(view.location()).isEqualTo("file://tmp/ns/view");
+    if (!overridesRequestedLocation()) {
+      assertThat(view.location()).isEqualTo("file://tmp/ns/view");
+    } else {
+      assertThat(view.location()).isNotNull();
+    }
 
     view.updateLocation().setLocation("file://updated_tmp/ns/view").commit();
 
     View updatedView = catalog().loadView(identifier);
 
-    assertThat(updatedView.location()).isEqualTo("file://updated_tmp/ns/view");
+    if (!overridesRequestedLocation()) {
+      assertThat(updatedView.location()).isEqualTo("file://updated_tmp/ns/view");
+    } else {
+      assertThat(view.location()).isNotNull();
+    }
 
     // history and view versions should stay the same after updating view properties
     assertThat(updatedView.history()).hasSize(1).isEqualTo(view.history());