address comments

apache · Jan 16, 2024 · 67eb872 · 67eb872
1 parent d2e6e98
commit 67eb872
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java b/core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
@@ -38,7 +38,7 @@ public class RewriteDataFilesCommitManager {
   private final Table table;
   private final long startingSnapshotId;
   private final boolean useStartingSequenceNumber;
-  private final Map<String, String> extraCommitSummary;
+  private final Map<String, String> snapshotProperties;
 
   // constructor used for testing
   public RewriteDataFilesCommitManager(Table table) {
@@ -58,11 +58,11 @@ public RewriteDataFilesCommitManager(
       Table table,
       long startingSnapshotId,
       boolean useStartingSequenceNumber,
-      Map<String, String> extraCommitSummary) {
+      Map<String, String> snapshotProperties) {
     this.table = table;
     this.startingSnapshotId = startingSnapshotId;
     this.useStartingSequenceNumber = useStartingSequenceNumber;
-    this.extraCommitSummary = extraCommitSummary;
+    this.snapshotProperties = snapshotProperties;
   }
 
   /**
@@ -87,7 +87,7 @@ public void commitFileGroups(Set<RewriteFileGroup> fileGroups) {
       rewrite.rewriteFiles(rewrittenDataFiles, addedDataFiles);
     }
 
-    extraCommitSummary.forEach(rewrite::set);
+    snapshotProperties.forEach(rewrite::set);
 
     rewrite.commit();
   }

diff --git a/core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesCommitManager.java b/core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesCommitManager.java
@@ -41,16 +41,16 @@ public class RewritePositionDeletesCommitManager {
 
   private final Table table;
   private final long startingSnapshotId;
-  private final Map<String, String> extraCommitSummary;
+  private final Map<String, String> snapshotProperties;
 
   public RewritePositionDeletesCommitManager(Table table) {
     this(table, ImmutableMap.of());
   }
 
-  public RewritePositionDeletesCommitManager(Table table, Map<String, String> extraCommitSummary) {
+  public RewritePositionDeletesCommitManager(Table table, Map<String, String> snapshotProperties) {
     this.table = table;
     this.startingSnapshotId = table.currentSnapshot().snapshotId();
-    this.extraCommitSummary = extraCommitSummary;
+    this.snapshotProperties = snapshotProperties;
   }
 
   /**
@@ -72,7 +72,7 @@ public void commit(Set<RewritePositionDeletesGroup> fileGroups) {
       }
     }
 
-    extraCommitSummary.forEach(rewriteFiles::set);
+    snapshotProperties.forEach(rewriteFiles::set);
 
     rewriteFiles.commit();
   }

diff --git a/...v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java b/...v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
@@ -1452,7 +1452,7 @@ public void testSnapshotProperty() {
     Result ignored = basicRewrite(table).snapshotProperty("key", "value").execute();
     assertThat(table.currentSnapshot().summary())
         .containsAllEntriesOf(ImmutableMap.of("key", "value"));
-    // make sure internal produced properties is not lost
+    // make sure internal produced properties are not lost
     String[] commitMetricsKeys =
         new String[] {
           SnapshotSummary.ADDED_FILES_PROP,

diff --git a/.../src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java b/.../src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java
@@ -633,7 +633,7 @@ public void testSnapshotProperty() throws Exception {
     assertThat(table.currentSnapshot().summary())
         .containsAllEntriesOf(ImmutableMap.of("key", "value"));
 
-    // make sure internal produced properties is not lost
+    // make sure internal produced properties are not lost
     String[] commitMetricsKeys =
         new String[] {
           SnapshotSummary.ADDED_DELETE_FILES_PROP,