-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Hive: Refactor hive-table commit operation to be used for other opera…
…tions like view.
- Loading branch information
Showing
6 changed files
with
367 additions
and
244 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
core/src/main/java/org/apache/iceberg/util/BaseMetastoreOperations.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.iceberg.util; | ||
|
|
||
| import static org.apache.iceberg.TableProperties.COMMIT_NUM_STATUS_CHECKS; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_NUM_STATUS_CHECKS_DEFAULT; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_MAX_WAIT_MS; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_MIN_WAIT_MS; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS; | ||
| import static org.apache.iceberg.TableProperties.COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS_DEFAULT; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
| import java.util.function.Function; | ||
| import org.apache.iceberg.BaseMetastoreTableOperations; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class BaseMetastoreOperations { | ||
| private static final Logger LOG = LoggerFactory.getLogger(BaseMetastoreOperations.class); | ||
|
|
||
| /** | ||
| * Attempt to load the table and see if any current or past metadata location matches the one we | ||
| * were attempting to set. This is used as a last resort when we are dealing with exceptions that | ||
| * may indicate the commit has failed but are not proof that this is the case. Past locations must | ||
| * also be searched on the chance that a second committer was able to successfully commit on top | ||
| * of our commit. | ||
| * | ||
| * @param tableName full name of the table | ||
| * @param newMetadataLocation the path of the new commit file | ||
| * @param properties properties for retry | ||
| * @param commitStatusSupplier calculate commit status with updated location | ||
| * @return Commit Status of Success, Failure or Unknown | ||
| */ | ||
| public BaseMetastoreTableOperations.CommitStatus checkCommitStatus( | ||
| String tableName, | ||
| String newMetadataLocation, | ||
| Map<String, String> properties, | ||
| Function<String, Boolean> commitStatusSupplier) { | ||
| int maxAttempts = | ||
| PropertyUtil.propertyAsInt( | ||
| properties, COMMIT_NUM_STATUS_CHECKS, COMMIT_NUM_STATUS_CHECKS_DEFAULT); | ||
| long minWaitMs = | ||
| PropertyUtil.propertyAsLong( | ||
| properties, COMMIT_STATUS_CHECKS_MIN_WAIT_MS, COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT); | ||
| long maxWaitMs = | ||
| PropertyUtil.propertyAsLong( | ||
| properties, COMMIT_STATUS_CHECKS_MAX_WAIT_MS, COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT); | ||
| long totalRetryMs = | ||
| PropertyUtil.propertyAsLong( | ||
| properties, | ||
| COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS, | ||
| COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS_DEFAULT); | ||
|
|
||
| AtomicReference<BaseMetastoreTableOperations.CommitStatus> status = | ||
| new AtomicReference<>(BaseMetastoreTableOperations.CommitStatus.UNKNOWN); | ||
|
|
||
| Tasks.foreach(newMetadataLocation) | ||
| .retry(maxAttempts) | ||
| .suppressFailureWhenFinished() | ||
| .exponentialBackoff(minWaitMs, maxWaitMs, totalRetryMs, 2.0) | ||
| .onFailure( | ||
| (location, checkException) -> | ||
| LOG.error("Cannot check if commit to {} exists.", tableName, checkException)) | ||
| .run( | ||
| location -> { | ||
| boolean commitSuccess = commitStatusSupplier.apply(newMetadataLocation); | ||
|
|
||
| if (commitSuccess) { | ||
| LOG.info( | ||
| "Commit status check: Commit to {} of {} succeeded", | ||
| tableName, | ||
| newMetadataLocation); | ||
| status.set(BaseMetastoreTableOperations.CommitStatus.SUCCESS); | ||
| } else { | ||
| LOG.warn( | ||
| "Commit status check: Commit to {} of {} unknown, new metadata location is not current " | ||
| + "or in history", | ||
| tableName, | ||
| newMetadataLocation); | ||
| } | ||
| }); | ||
|
|
||
| if (status.get() == BaseMetastoreTableOperations.CommitStatus.UNKNOWN) { | ||
| LOG.error( | ||
| "Cannot determine commit state to {}. Failed during checking {} times. " | ||
| + "Treating commit state as unknown.", | ||
| tableName, | ||
| maxAttempts); | ||
| } | ||
| return status.get(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.