Skip to content

Commit

Permalink
API: Define RepairManifests action interface
Browse files Browse the repository at this point in the history
Co-authored-by: Mathew Fournier <[email protected]>
  • Loading branch information
amogh-jahagirdar and tabmatfournier committed Aug 1, 2024
1 parent 4a0ae22 commit 4b2ddfe
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,10 @@ default RewritePositionDeleteFiles rewritePositionDeletes(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement rewritePositionDeletes");
}

/** Instantiates an action to repair manifests */
default RepairManifests repairManifests(Table table) {
throw new UnsupportedOperationException(
this.getClass().getName() + " does not implement repairManifests");
}
}
62 changes: 62 additions & 0 deletions api/src/main/java/org/apache/iceberg/actions/RepairManifests.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.iceberg.actions;

import org.apache.iceberg.ManifestFile;

/** An action that will repair manifests. Implementations should produce a new set of manifests. */
public interface RepairManifests extends SnapshotUpdate<RepairManifests, RepairManifests.Result> {

/**
* Configuration method for removing duplicate file entries and removing files which no longer
* exist in storage
*/
RepairManifests repairEntryStats();

/**
* Configuration method for removing duplicate file entries and removing files which no longer
* exist in storage
*/
RepairManifests repairFileEntries();

/**
* Determine the rewritten and added manifests without actually committing the operation to the
* table
*
* @return this for method chaining
*/
RepairManifests dryRun();

interface Result {
/** Returns rewritten manifests. */
Iterable<ManifestFile> rewrittenManifests();

/** Returns added manifests. */
Iterable<ManifestFile> addedManifests();

/** Returns the duplicate file paths removed */
Iterable<String> duplicateFilesRemoved();

/** Returns the paths of the missing files which were removed */
Iterable<String> missingFilesRemoved();

/** Returns the paths of the missing files which were recovered */
Iterable<String> missingFilesRecovered();
}
}

0 comments on commit 4b2ddfe

Please sign in to comment.