Added error handling and default logic for Flink version detection

apache · Jan 9, 2024 · 4384e94 · 4384e94
1 parent 7428ec2
commit 4384e94
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/util/TestFlinkPackage.java b/flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/util/TestFlinkPackage.java
@@ -38,8 +38,8 @@ public void testVersion() {
 
   @Test
   public void testDefaultVersion() {
-    // It's difficult to reproduce a reflection error in a unit test, so we just inject a mocked fault to test
-    // the default logic
+    // It's difficult to reproduce a reflection error in a unit test, so we just inject a mocked
+    // fault to test the default logic
     FlinkVersionDetector detectorWithReflectionError = Mockito.spy(FlinkVersionDetector.class);
     Mockito.when(detectorWithReflectionError.getVersionFromJar()).thenThrow(RuntimeException.class);
     FlinkPackage.setVersionDetector(detectorWithReflectionError);

diff --git a/flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/util/TestFlinkPackage.java b/flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/util/TestFlinkPackage.java
@@ -39,8 +39,7 @@ public void testVersion() {
   @Test
   public void testDefaultVersion() {
     // It's difficult to reproduce a reflection error in a unit test, so we just inject a mocked
-    // fault to test
-    // the default logic
+    // fault to test the default logic
     FlinkVersionDetector detectorWithReflectionError = Mockito.spy(FlinkVersionDetector.class);
     Mockito.when(detectorWithReflectionError.getVersionFromJar()).thenThrow(RuntimeException.class);
     FlinkPackage.setVersionDetector(detectorWithReflectionError);