Core: Enable strict metadata cleanup by default (#8599)

apache · Sep 20, 2023 · 31651e8 · 31651e8
1 parent 47ae4ac
commit 31651e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/TableOperations.java b/core/src/main/java/org/apache/iceberg/TableOperations.java
@@ -121,9 +121,10 @@ default long newSnapshotId() {
    * Whether to clean up uncommitted metadata files only when a commit fails with a {@link
    * CleanableFailure} exception.
    *
-   * <p>This defaults to false: any unexpected exception will cause metadata files to be cleaned up.
+   * <p>This defaults to true: cleanup will only occur for exceptions marked as {@link
+   * CleanableFailure}
    */
   default boolean requireStrictCleanup() {
-    return false;
+    return true;
   }
 }
diff --git a/core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java b/core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java
@@ -240,9 +240,4 @@ public long newSnapshotId() {
       }
     };
   }
-
-  @Override
-  public boolean requireStrictCleanup() {
-    return true;
-  }
 }