AuthManager constructor

apache · Dec 19, 2024 · 2a3f4af · 2a3f4af
1 parent 52f4423
commit 2a3f4af
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java b/core/src/main/java/org/apache/iceberg/rest/auth/AuthManagers.java
@@ -53,7 +53,6 @@ public static AuthManager loadAuthManager(String name, Map<String, String> prope
           DynConstructors.builder(AuthManager.class)
               .loader(AuthManagers.class.getClassLoader())
               .impl(impl, String.class) // with name
-              .impl(impl) // without name
               .buildChecked();
     } catch (NoSuchMethodException e) {
       throw new IllegalArgumentException(

diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/BasicAuthManager.java b/core/src/main/java/org/apache/iceberg/rest/auth/BasicAuthManager.java
@@ -26,6 +26,10 @@
 /** An auth manager that adds static BASIC authentication data to outgoing HTTP requests. */
 public final class BasicAuthManager implements AuthManager {
 
+  public BasicAuthManager(String ignored) {
+    // no-op
+  }
+
   @Override
   public AuthSession catalogSession(RESTClient sharedClient, Map<String, String> properties) {
     Preconditions.checkArgument(

diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/NoopAuthManager.java b/core/src/main/java/org/apache/iceberg/rest/auth/NoopAuthManager.java
@@ -24,6 +24,10 @@
 /** An auth manager that does not add any authentication data to outgoing HTTP requests. */
 public class NoopAuthManager implements AuthManager {
 
+  public NoopAuthManager(String ignored) {
+    // no-op
+  }
+
   @Override
   public AuthSession catalogSession(RESTClient sharedClient, Map<String, String> properties) {
     return AuthSession.EMPTY;

diff --git a/core/src/test/java/org/apache/iceberg/rest/auth/TestBasicAuthManager.java b/core/src/test/java/org/apache/iceberg/rest/auth/TestBasicAuthManager.java
@@ -29,7 +29,7 @@ class TestBasicAuthManager {
 
   @Test
   void missingUsername() {
-    try (AuthManager authManager = new BasicAuthManager()) {
+    try (AuthManager authManager = new BasicAuthManager("test")) {
       assertThatThrownBy(() -> authManager.catalogSession(null, Map.of()))
           .isInstanceOf(IllegalArgumentException.class)
           .hasMessage(
@@ -39,7 +39,7 @@ void missingUsername() {
 
   @Test
   void missingPassword() {
-    try (AuthManager authManager = new BasicAuthManager()) {
+    try (AuthManager authManager = new BasicAuthManager("test")) {
       Map<String, String> properties = Map.of(AuthProperties.BASIC_USERNAME, "alice");
       assertThatThrownBy(() -> authManager.catalogSession(null, properties))
           .isInstanceOf(IllegalArgumentException.class)
@@ -52,7 +52,7 @@ void missingPassword() {
   void success() {
     Map<String, String> properties =
         Map.of(AuthProperties.BASIC_USERNAME, "alice", AuthProperties.BASIC_PASSWORD, "secret");
-    try (AuthManager authManager = new BasicAuthManager();
+    try (AuthManager authManager = new BasicAuthManager("test");
         AuthSession session = authManager.catalogSession(null, properties)) {
       assertThat(session)
           .isEqualTo(