[review] close()

apache · Dec 18, 2024 · 28db239 · 28db239
1 parent fdd1941
commit 28db239
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java b/core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java
@@ -102,7 +102,5 @@ default AuthSession tableSession(
    * <p>This method is called when the owning catalog is closed.
    */
   @Override
-  default void close() {
-    // Do nothing
-  }
+  void close();
 }
diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/BasicAuthManager.java b/core/src/main/java/org/apache/iceberg/rest/auth/BasicAuthManager.java
@@ -41,4 +41,9 @@ public AuthSession mainSession(RESTClient sharedClient, Map<String, String> prop
     String credentials = username + ":" + password;
     return DefaultAuthSession.of(HTTPHeaders.of(OAuth2Util.basicAuthHeaders(credentials)));
   }
+
+  @Override
+  public void close() {
+    // no resources to close
+  }
 }
diff --git a/core/src/main/java/org/apache/iceberg/rest/auth/NoopAuthManager.java b/core/src/main/java/org/apache/iceberg/rest/auth/NoopAuthManager.java
@@ -28,4 +28,9 @@ public class NoopAuthManager implements AuthManager {
   public AuthSession mainSession(RESTClient sharedClient, Map<String, String> properties) {
     return AuthSession.EMPTY;
   }
+
+  @Override
+  public void close() {
+    // no resources to close
+  }
 }