Arrow: Deprecate unused fixed width binary reader classes (#11292)

apache · Oct 14, 2024 · 12ff959 · 12ff959
1 parent 7912035
commit 12ff959
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/...w/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java b/...w/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java
@@ -214,6 +214,10 @@ protected int nextBatchOf(
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public class FixedWidthTypeBinaryBatchReader extends BatchReader {
     @Override
     protected int nextBatchOf(
@@ -278,6 +282,10 @@ public VarWidthTypeBatchReader varWidthTypeBatchReader() {
     return new VarWidthTypeBatchReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public FixedWidthTypeBinaryBatchReader fixedWidthTypeBinaryBatchReader() {
     return new FixedWidthTypeBinaryBatchReader();
   }

diff --git a/...ache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java b/...ache/iceberg/arrow/vectorized/parquet/VectorizedDictionaryEncodedParquetValuesReader.java
@@ -141,6 +141,10 @@ protected void nextVal(
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   class FixedWidthBinaryDictEncodedReader extends BaseDictEncodedReader {
     @Override
     protected void nextVal(
@@ -203,6 +207,10 @@ public DoubleDictEncodedReader doubleDictEncodedReader() {
     return new DoubleDictEncodedReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   public FixedWidthBinaryDictEncodedReader fixedWidthBinaryDictEncodedReader() {
     return new FixedWidthBinaryDictEncodedReader();
   }

diff --git a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedPageIterator.java
@@ -421,7 +421,10 @@ protected void nextDictEncodedVal(
    * Method for reading batches of fixed width binary type (e.g. BYTE[7]). Spark does not support
    * fixed width binary data type. To work around this limitation, the data is read as fixed width
    * binary from parquet and stored in a {@link VarBinaryVector} in Arrow.
+   *
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
    */
+  @Deprecated
   class FixedWidthBinaryPageReader extends BasePageReader {
     @Override
     protected void nextVal(
@@ -496,6 +499,10 @@ VarWidthTypePageReader varWidthTypePageReader() {
     return new VarWidthTypePageReader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   FixedWidthBinaryPageReader fixedWidthBinaryPageReader() {
     return new FixedWidthBinaryPageReader();
   }

diff --git a/...a/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java b/...a/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
@@ -493,6 +493,10 @@ protected void nextDictEncodedVal(
     }
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   class FixedWidthBinaryReader extends BaseReader {
     @Override
     protected void nextVal(
@@ -732,6 +736,10 @@ TimestampInt96Reader timestampInt96Reader() {
     return new TimestampInt96Reader();
   }
 
+  /**
+   * @deprecated since 1.7.0, will be removed in 1.8.0.
+   */
+  @Deprecated
   FixedWidthBinaryReader fixedWidthBinaryReader() {
     return new FixedWidthBinaryReader();
   }