Merge pull request #7 from PickBas/fix-8810-mr

[ISSUE #8810] mr/*: replaced .size() > 0 with isEmpty()
apache · Oct 13, 2023 · 00e0b25 · 00e0b25
2 parents 54cb4fc + 39f5ba6
commit 00e0b25
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java b/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
@@ -269,7 +269,7 @@ public void abortJob(JobContext originalContext, int status) throws IOException
                     dataFiles(fileExecutor, table.location(), jobContext, table.io(), false);
 
                 // Check if we have files already committed and remove data files if there are any
-                if (dataFiles.size() > 0) {
+                if (!dataFiles.isEmpty()) {
                   Tasks.foreach(dataFiles)
                       .retry(3)
                       .suppressFailureWhenFinished()
@@ -327,7 +327,7 @@ private void commitTable(
 
     Collection<DataFile> dataFiles = dataFiles(executor, location, jobContext, io, true);
 
-    if (dataFiles.size() > 0) {
+    if (!dataFiles.isEmpty()) {
       // Appending data files to the table
       AppendFiles append = table.newAppend();
       dataFiles.forEach(append::appendFile);