feat: support scan nested type(struct, map, list) #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
support_nested
branch
from
17b7645 to
d744a4d
Compare
sdd
reviewed
Jan 9, 2025
crates/iceberg/src/arrow/schema.rs
Outdated
| /// UTC time zone for Arrow timestamp type. | ||
| pub const UTC_TIME_ZONE: &str = "+00:00"; | ||
| /// When iceberg map type convert to Arrow map type, the default map field name is "key_value". | ||
| pub const MAP_KEY_VALUE_FIELD_NAME: &str = "key_value"; |
There was a problem hiding this comment.
how does this differ from DEFAULT_MAP_FIELD_NAME above? The descriptions in their comments are the same.
There was a problem hiding this comment.
Nice catch. Remove duplicate one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support to scan nested type