feat(datafusion): support metadata tables for Datafusion #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
force-pushed
the
xxchan/datafusion-metadata
branch
from
d25b534 to
ecf8729
Compare
xxchan
commented
Jan 5, 2025
| [table_name.clone()] | ||
| .into_iter() | ||
| .chain(MetadataTableType::all_types().map(|metadata_table_name| { | ||
| format!("{}${}", table_name.clone(), metadata_table_name.as_str()) |
There was a problem hiding this comment.
The $ syntax follows Flink https://iceberg.apache.org/docs/1.5.2/flink-queries/#inspecting-tables instead of . from Spark, because 4-level catalog.schema.table.metadata is not supported in Datafusion.
xxchan
commented
Jan 5, 2025
Comment on lines
+344
to
+348
| expect![[r#" | ||
| committed_at: PrimitiveArray<Timestamp(Millisecond, Some("+00:00"))> | ||
| [ | ||
| ], | ||
| snapshot_id: PrimitiveArray<Int64> |
There was a problem hiding this comment.
Currently the datafusion test cases don't have any data present so this is empty
xxchan
force-pushed
the
xxchan/datafusion-metadata
branch
from
ecf8729 to
726b0fc
Compare
kevinjqliu
reviewed
Jan 6, 2025
xxchan
force-pushed
the
xxchan/datafusion-metadata
branch
from
4886b8e to
90abb68
Compare
xxchan
commented
Jan 8, 2025
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/datafusion-metadata
branch
from
90abb68 to
0b0af5d
Compare
|
Sorry, closed by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the newly added metadata tables #823 to support this feature in Datafusion engine to demonstrate its usage.
This may also potentially help design and stablize the interface of metadata tables in the
icebergcrate.