feat: Support metadata table "Manifests" #861
Conversation
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
|
#822 has been merged, let's move on! |
flaneur2020
force-pushed
the
feat/manifests-table
branch
from
7693dd5 to
940ddc1
Compare
|
@Xuanwo merged the main branch, PTAL 🫡 |
crates/iceberg/src/metadata_scan.rs
Outdated
| /// Get the manifests table. | ||
| pub fn manifests(&self) -> ManifestsTable { | ||
| ManifestsTable { | ||
| metadata_table: self, |
There was a problem hiding this comment.
Hi, I think we can simply use Table here, which suggests that MetadataTable is merely a wrapper and doesn't implement any additional API.
There was a problem hiding this comment.
fixed in 9fe6bd0, PTAL
crates/iceberg/src/metadata_scan.rs
Outdated
| ) | ||
| .await?; | ||
| for manifest in manifest_list.entries() { | ||
| content.append_value(manifest.content.clone() as i8); |
There was a problem hiding this comment.
It's a bit unusual to see something that can use as u8 but still requires clone.
There was a problem hiding this comment.
We may derive Copy for ManifestContentType
There was a problem hiding this comment.
fixed in 4c6e338
crates/iceberg/src/metadata_scan.rs
Outdated
| ] | ||
| } | ||
|
|
||
| fn schema(&self) -> Schema { |
There was a problem hiding this comment.
We might want to make this pub, so engines can get the schema first without fetching the data.
There was a problem hiding this comment.
fixed in 83e8811
There was a problem hiding this comment.
Thank you @flaneur2020 for this, and thank you @xxchan's review, let's move!
| } | ||
|
|
||
| /// Returns the schema of the manifests table. | ||
| pub fn schema(&self) -> Schema { |
There was a problem hiding this comment.
I think we should return iceberg schema here, and user could easily convert it to arrow schema.
There was a problem hiding this comment.
I think we should return iceberg schema here, and user could easily convert it to arrow schema.
Would you like to create an issue for this?
Re #823. Extends @xxchan's #822 to add support for the Manifests metadata table. (I'll rebase and update this PR once #822 merges.)
This PR also made two small changes to make it possible to pass the test about manifests table:
iotoMetadataScanMetadataTablean async trait to allow us load manifests in the impl.there're related comments in #823, we can rebase this pr after #823 updated.
Reference implementations:
Java
PyIceberg