feat: support serialize/deserialize DataFile into avro bytes #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
expose_data_file
branch
from
0218dc7 to
f766445
Compare
ZENOTME
force-pushed
the
expose_data_file
branch
from
f766445 to
b94c978
Compare
|
I change this PR to add interface to help serialize/deserialize DataFile into avro bytes. The idea comes from #774 (comment). I think it can be a good start for #774. It provides the interface to let user serialize/deserialize the DataFile. In later, we can discuss whether to let DataFile itself serializable and essentially, it means that we should contain more info in the DataFile and we don't need to provide the info(e.g. partition type) as parameters in the interface. |
ZENOTME
changed the title
There was a problem hiding this comment.
Thanks @ZENOTME for this pr. Left some suggestions to improve api consistency, others LGTM.
crates/iceberg/src/spec/manifest.rs
Outdated
| @@ -656,6 +656,38 @@ mod _const_schema { | |||
| }) | |||
| }; | |||
|
|
|||
| fn data_file_fields_v2(partition_type: StructType) -> Vec<NestedFieldRef> { | |||
There was a problem hiding this comment.
Suggested change
| fn data_file_fields_v2(partition_type: StructType) -> Vec<NestedFieldRef> { | |
| fn data_file_fields_v2(partition_type: &StructType) -> Vec<NestedFieldRef> { |
crates/iceberg/src/spec/manifest.rs
Outdated
| ] | ||
| } | ||
|
|
||
| pub(super) fn data_file_schema_v2(partition_type: StructType) -> Result<AvroSchema, Error> { |
There was a problem hiding this comment.
Suggested change
| pub(super) fn data_file_schema_v2(partition_type: StructType) -> Result<AvroSchema, Error> { | |
| pub(super) fn data_file_schema_v2(partition_type: &StructType) -> Result<AvroSchema, Error> { |
crates/iceberg/src/spec/manifest.rs
Outdated
| )), | ||
| ]; | ||
| let schema = Schema::builder().with_fields(fields).build()?; | ||
| schema_to_avro_schema("manifest_entry", &schema) | ||
| } | ||
|
|
||
| fn data_file_fields_v1(partition_type: StructType) -> Vec<NestedFieldRef> { |
There was a problem hiding this comment.
Suggested change
| fn data_file_fields_v1(partition_type: StructType) -> Vec<NestedFieldRef> { | |
| fn data_file_fields_v1(partition_type: &StructType) -> Vec<NestedFieldRef> { |
Xuanwo
reviewed
Dec 31, 2024
Xuanwo
reviewed
Jan 2, 2025
ZENOTME
force-pushed
the
expose_data_file
branch
from
eb7270e to
92871af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the _serde::DataFile so that the user can serialize && deserialize the data file. related issue: #774