Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the build from source section #70

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

git-hulk
Copy link
Member

It will be better to add the build instruction for the newcomers
even though it might be straight for Go develop to find where's main.go file.

By the way, I'm wondering if adding the Makefile to manage the build and test instructions
is good. If yes, I would submit a PR to resolve this.

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably fine, but I don't think there's any need for a makefile

README.md Show resolved Hide resolved
@Fokko Fokko merged commit 6d9987e into apache:main Jun 24, 2024
5 checks passed
@Fokko
Copy link
Contributor

Fokko commented Jun 24, 2024

Thanks for the PR @git-hulk and @zeroshade for the review! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants