Implemented Remaining Catalog operations for REST catalog #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chil-pavn In general this is looking good, I'll give it a more in-depth review in the next couple days. Could you add some unit tests for these as we have for the other functions? (basically just mocking out the server responses with a local http server) |
piyushsingariya
suggested changes
Dec 30, 2024
Comment on lines
+784
to
+787
| ns, tbl, err := splitIdentForPath(identifier) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Suggested change
| ns, tbl, err := splitIdentForPath(identifier) | |
| if err != nil { | |
| return nil, err | |
| } | |
| namespace, table, err := splitIdentifierForPath(identifier) | |
| if err != nil { | |
| return nil, err | |
| } |
There was a problem hiding this comment.
I agree that the suggestions are more detailed. But ns, tbl, and Props are consistently used throughout the codebase
| id = append([]string{r.name}, identifier...) | ||
| } | ||
|
|
||
| tblProps := maps.Clone(r.props) |
There was a problem hiding this comment.
Suggested change
| tblProps := maps.Clone(r.props) | |
| tableProperties := maps.Clone(r.props) |
zeroshade
reviewed
Jan 2, 2025
README.md
Outdated
Comment on lines
1
to
34
| <!-- | ||
| - Licensed to the Apache Software Foundation (ASF) under one or more | ||
| - contributor license agreements. See the NOTICE file distributed with | ||
| - this work for additional information regarding copyright ownership. | ||
| - The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| - (the "License"); you may not use this file except in compliance with | ||
| - the License. You may obtain a copy of the License at | ||
| - | ||
| - http://www.apache.org/licenses/LICENSE-2.0 | ||
| - | ||
| - Unless required by applicable law or agreed to in writing, software | ||
| - distributed under the License is distributed on an "AS IS" BASIS, | ||
| - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| - See the License for the specific language governing permissions and | ||
| - limitations under the License. | ||
| --> | ||
|
|
||
| # Iceberg Golang | ||
|
|
||
| [](https://pkg.go.dev/github.com/apache/iceberg-go) | ||
|
|
||
| `iceberg` is a Golang implementation of the [Iceberg table spec](https://iceberg.apache.org/spec/). | ||
|
|
||
| ## Build From Source | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| * Go 1.21 or later | ||
|
|
||
| ### Build | ||
|
|
||
| ```shell | ||
| $ git clone https://github.com/apache/iceberg-go.git | ||
| $ cd iceberg-go/cmd/iceberg && go build . |
There was a problem hiding this comment.
Ahhh ! my bad. This wasn't intended.
zeroshade
reviewed
Jan 3, 2025
Comment on lines
+659
to
+668
| payload := map[string]interface{}{ | ||
| "source": map[string]interface{}{ | ||
| "namespace": strings.Split(fromNs, namespaceSeparator), | ||
| "name": fromTbl, | ||
| }, | ||
| "destination": map[string]interface{}{ | ||
| "namespace": strings.Split(toNs, namespaceSeparator), | ||
| "name": toTbl, | ||
| }, | ||
| } |
There was a problem hiding this comment.
any reason not to create a struct for this instead of the maps?
zeroshade
reviewed
Jan 3, 2025
Comment on lines
+821
to
+823
| for k, v := range ret.Config { | ||
| tblProps[k] = v | ||
| } |
There was a problem hiding this comment.
maps.Copy(tblProps, ret.Config)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63 . Tried implementing createTable, dropTable and renameTable methods taking reference to loadTable and rest-catalog-open-api.