release_rc.sh upload artifacts to apache dist #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Dec 27, 2024
dev/release/release_rc.sh
Outdated
| id="apache-iceberg-go-${version}-rc${rc}" | ||
| id="apache-iceberg-go-${version}" |
There was a problem hiding this comment.
Why this change? Doesn't the tar file need to have -rc${rc} in the name?
There was a problem hiding this comment.
apache-iceberg-go-${version}-rc${rc} is the general convention to follow for release candidates. However apache-iceberg and apache-iceberg-rust are doing it this way.
There was a problem hiding this comment.
I have also checked a few other apache releases and it looks like some follow and some don't.
I have added a new commit with the tar ball naming as suggested as to keep it consistent with our 0.1.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #204
Added code to upload to apache dist.