HTTPCLIENT-2293 - Implement RFC-compliant TRACE request interceptor #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Sep 20, 2023
•
arturobernalg
commented
- Add RequestTraceInterceptor class to handle HTTP TRACE requests in compliance with RFC 7231, Section 4.3.8.
- Throw ProtocolException for sensitive headers like 'Authorization' and 'Cookie' in TRACE requests.
- Throw ProtocolException if TRACE request contains a body.
|
Please @reschke take a look |
arturobernalg
force-pushed
the
HTTPCLIENT-2293-trace
branch
from
6d6b0cc
to
3fbc8b1
Compare
ok2c
reviewed
Sep 22, 2023
| } | ||
|
|
||
| // Check for sensitive headers | ||
| final Header authHeader = request.getHeader(HttpHeaders.AUTHORIZATION); |
There was a problem hiding this comment.
@arturobernalg I really dislike the idea of removing headers explicitly set by the caller. It feels wrong. Would you be OK with throwing a protocol exception instead?
There was a problem hiding this comment.
Fair enough. changed
arturobernalg
force-pushed
the
HTTPCLIENT-2293-trace
branch
from
eb11638
to
7cba85b
Compare
ok2c
approved these changes
Sep 23, 2023
arturobernalg
force-pushed
the
HTTPCLIENT-2293-trace
branch
from
7cba85b
to
f3d3abd
Compare
- Add RequestTraceInterceptor class to handle HTTP TRACE requests in compliance with RFC 7231, Section 4.3.8. - Throw ProtocolException for sensitive headers like 'Authorization' and 'Cookie' in TRACE requests. - Throw ProtocolException if TRACE request contains a body.
arturobernalg
force-pushed
the
HTTPCLIENT-2293-trace
branch
from
f3d3abd
to
2b28d04
Compare
ok2c
pushed a commit
that referenced
this pull request
Dec 13, 2023
…486) - Add RequestTraceInterceptor class to handle HTTP TRACE requests in compliance with RFC 7231, Section 4.3.8. - Throw ProtocolException for sensitive headers like 'Authorization' and 'Cookie' in TRACE requests. - Throw ProtocolException if TRACE request contains a body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.