HTTPCLIENT-2277: deprecation of obsolete config parameters and removal of oudated or meaningless tests #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…required by RFC 9111
…mmendation test cases: * Removed links to RFC 2616 * Removed verbatim quotes from RFC 2616 * Removed obsolete test cases and test cases without result verification / assertions * Removed test cases unrelated to HTTP caching * Removed test cases without test result assertions
| public boolean is303CachingEnabled() { | ||
| return allow303Caching; | ||
| return true; |
There was a problem hiding this comment.
@ok2c Should the return value of the deprecated is303CachingEnabled() method be set to false to align with all the changes?
There was a problem hiding this comment.
@arturobernalg The cache protocol layer will now be treating 303 responses as potentially cacheable by default. This is why I thought the deprecated method should also return true. Does that make sense?
There was a problem hiding this comment.
@ok2c that its correct. my bad.
ok2c
added a commit
that referenced
this pull request
Dec 13, 2023
…l of oudated or meaningless tests (#484) * HTTPCLIENT-2277: Deprecated 303 response caching switch as no longer required by RFC 9111 * Javadoc improvements (no functional changes) * HTTPCLIENT-2277: Revision of HTTP cache protocol requirement and recommendation test cases: * Removed links to RFC 2616 * Removed verbatim quotes from RFC 2616 * Removed obsolete test cases and test cases without result verification / assertions * Removed test cases unrelated to HTTP caching * Removed test cases without test result assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arturobernalg Please kindly have a look. No functional changes. Mostly deprecation and removal of outdated / unused code and some javadoc updates. Also removed verbatim RFC 2616 quotes from the cache test cases.