Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPCLIENT-2277: internal cache API and cache update redesign #483

Merged
merged 2 commits into from
Sep 17, 2023

Conversation

ok2c
Copy link
Member

@ok2c ok2c commented Sep 14, 2023

Changes:

  • improved and simplified internal cache API
  • corrected cache update logic after a variant negotiation
  • more tests
  • fixed regression

…che hits returned by `BasicHttpCache#getVariants`
* improved and simplified internal cache API
* corrected cache update logic after a variant negotiation
* added more tests
@ok2c
Copy link
Member Author

ok2c commented Sep 14, 2023

@arturobernalg You do not need to understand every detail in the change-set, just see if you can spot something obviously wrong or crazy

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c The change-set looks good.

@ok2c ok2c merged commit 3b756f2 into 5.4.x Sep 17, 2023
13 checks passed
@ok2c ok2c deleted the HTTPCLIENT-2277 branch September 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants