HTTPCLIENT-2293 Enforce Port Specification for CONNECT Request #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
approved these changes
Sep 14, 2023
| HttpHost host = target; | ||
| if (host.getPort() <= 0) { | ||
| host = new HttpHost(host.getSchemeName(), host.getHostName(), 80); | ||
| if (target.getPort() <= 0) { |
There was a problem hiding this comment.
@arturobernalg It would be nicer (and more consistent) to use Args#check here but not a deal breaker.
There was a problem hiding this comment.
@ok2c
True. changed.
…r RFC 9110 - This adheres to RFC 9110, which states: "There is no default port; a client MUST send the port number even if the CONNECT request is based on a URI reference that contains an authority component with an elided port.
arturobernalg
force-pushed
the
HTTPCLIENT-2293
branch
from
5cc2ac8
to
a81788e
Compare
ok2c
approved these changes
Sep 15, 2023
ok2c
pushed a commit
that referenced
this pull request
Dec 13, 2023
…r RFC 9110 (#482) - This adheres to RFC 9110, which states: "There is no default port; a client MUST send the port number even if the CONNECT request is based on a URI reference that contains an authority component with an elided port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a change to the ProxyClient class to ensure that a port is always specified when making a CONNECT request, in line with the requirements set out in RFC 9110.