HTTPCLIENT-2284: Cache entry representation improvements #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ok2c
commented
Aug 21, 2023
ok2c
commented
- request URI stored in cache is now normalized and is presently expected to be the same as the root key
- removed references to variant cache keys from the cache entry
- Variants in root entries are now represented as a set, not as a map
|
@arturobernalg Here's what I hope is going to be the last round of changes to the HttpCacheEntry and the related classes. This change-set should also help partially resolve HTTPCLIENT-2284 by making it easier to implement custom cleanup of evicted cache entries. |
arturobernalg
approved these changes
Aug 21, 2023
| @@ -328,7 +330,7 @@ public HttpCacheStorageEntry deserialize(final byte[] serializedObject) throws R | |||
| statusLine.getStatusCode(), | |||
| responseHeaders, | |||
| resource, | |||
| variantMap | |||
| !variants.isEmpty() ? variants : null | |||
There was a problem hiding this comment.
Shouldn't we delegate everything to the internal constructor of HttpCacheEntry? I think its redundant.
There was a problem hiding this comment.
Shouldn't we delegate everything to the internal constructor of
HttpCacheEntry? I think its redundant.
@arturobernalg I am not sure I understand. You mean the variants.isEmpty() check?
There was a problem hiding this comment.
@ok2c my bad. No change need it. Sorry about that
* request URI stored in cache is now normalized and is presently expected to be the same as the root key * removed references to variant cache keys from the cache entry * Variants in root entries are now represented as a set, not as a map
ok2c
added a commit
that referenced
this pull request
Dec 13, 2023
* request URI stored in cache is now normalized and is presently expected to be the same as the root key * removed references to variant cache keys from the cache entry * Variants in root entries are now represented as a set, not as a map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.