GUACAMOLE-1701: Implement connection date and time before and after restrictions. #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind posting a screenshot demonstrating what this woud look like? |
Sure, I've edited the original post and added that :-). |
jmuehlner
reviewed
Oct 15, 2024
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
jmuehlner
reviewed
Oct 15, 2024
...guacamole-auth-restrict/src/main/resources/controllers/dateTimeRestrictionFieldController.js
Outdated
Show resolved
Hide resolved
jmuehlner
reviewed
Oct 15, 2024
...guacamole-auth-restrict/src/main/resources/controllers/dateTimeRestrictionFieldController.js
Outdated
Show resolved
Hide resolved
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements an additional restriction type in the guacamole-auth-restrict extension that allows
ConnectionandConnectionGroupobjects to be made available only after a certain date and/or only up to a certain date, adding to the overall ability to finely control when connections and connection groups are available. The changes will add the top two options in the following screenshot:Error messages will be similar to those thrown when the connection is restricted using the other (existing) options.