Update SpotBugs and fix new issues #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdemers
commented
Nov 21, 2023
•
bdemers
commented
- Bump com.github.spotbugs:spotbugs-maven-plugin from 4.7.3.6 to 4.8.1.0
- Move PatchOperationPath parsing into util method.
- Explicitly configure lombok annotation processor
Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.3.6 to 4.8.1.0. - [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases) - [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.3.6...spotbugs-maven-plugin-4.8.1.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Construction of object now happens in util method as to not be vunlerable to finalizer attacks. This is probably a nit, but SpotBugs/FindSecBugs flagged this issue in the latest update. There are a few other minor related issues flagged by the spotbugs upgrade as well - missing static keywords - fields that could be private
This will prevent build cache misses
bdemers
force-pushed
the
spot-bugs-updates
branch
from
998707f to
d97667f
Compare
bdemers
added a commit
that referenced
this pull request
Nov 29, 2023
* Bump com.github.spotbugs:spotbugs-maven-plugin from 4.7.3.6 to 4.8.1.0 Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.3.6 to 4.8.1.0. - [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases) - [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.3.6...spotbugs-maven-plugin-4.8.1.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Move PatchOperationPath parsing into util method. Construction of object now happens in util method as to not be vunlerable to finalizer attacks. This is probably a nit, but SpotBugs/FindSecBugs flagged this issue in the latest update. There are a few other minor related issues flagged by the spotbugs upgrade as well - missing static keywords - fields that could be private * Explicitly configure lombok annotation processor This will prevent build cache misses --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.