Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log spam and minor test cleanup #409

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Remove log spam and minor test cleanup #409

merged 3 commits into from
Nov 8, 2023

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Nov 8, 2023

  • Cleanup test log spam
  • Simplify try/catch/fail logic in PhoneNumberBuilderTest
  • Remove usage of assert keyword in ExpressionBuildingListener

@bdemers
Cleanup test log spam
184c4f9 
Remove usage of logger.info in tests
@bdemers
Simplify try/catch/fail logic in PhoneNumberBuilderTest
891a83f 
- Replace try/catch/fail blocks with assertJ lambda
- replace assert keyword with assertThat method
- replace LOGGER.info with .debug to remove log spam
@bdemers
Remove usage of assert keyword in ExpressionBuildingListener
855671d
@bdemers bdemers merged commit b91fee9 into develop Nov 8, 2023
2 checks passed
@bdemers bdemers deleted the test-log-spam-and-assert branch November 8, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdemers